[PATCH 2/2] Change tab widget names.

[Dirk Hohndel]

Patches like this to tool generated files always make me nervous. But I
guess I just need to learn to love them...

amit.k.chaudhuri at gmail.com writes:
> diff --git a/qt-ui/maintab.ui b/qt-ui/maintab.ui
> index a0aec43..1c9b9d1 100644
> --- a/qt-ui/maintab.ui
> +++ b/qt-ui/maintab.ui
> @@ -7,16 +7,16 @@
>      <x>0</x>
>      <y>0</y>
>      <width>400</width>
> -    <height>320</height>
> +    <height>334</height>

Is that relevant? Intentional? Caused by a different version of the
tool? A bug?

>     </rect>
>    </property>
>    <property name="windowTitle">
>     <string>TabWidget</string>
>    </property>
>    <property name="currentIndex">
> -   <number>0</number>
> +   <number>3</number>
>    </property>

How about this one? A number changes from 0 to 3. No mention of it in
the commit message...

> @@ -618,12 +618,12 @@
>      </item>
>      <item>
>       <layout class="QGridLayout" name="gridLayout_5">
> -      <property name="verticalSpacing">
> -       <number>10</number>
> -      </property>
>        <property name="bottomMargin">
>         <number>0</number>
>        </property>
> +      <property name="verticalSpacing">
> +       <number>10</number>
> +      </property>
>        <item row="0" column="0">
>         <widget class="QLabel" name="label_20">
>          <property name="font">

My personal favorite whenever I deal with machine generated files...

I'll just take the patch as is as it does appear to fix a warning
message, but considering that we'll soon have dozens of these files this
makes me wonder how I should deal with patches to them in the future...

Maybe we need a sub-maintainer (clearly one of the people doing the
majority of the work on the Qt UI) who simply owns the UI and gets to be
the one to make sure changes like this are sane and make sense?

How do other projects handle this, Thiago?

/D