[PATCH 2/2] Change tab widget names.

[Dirk Hohndel]

Thiago Macieira <thiago at macieira.org> writes:
>> > -    <height>320</height>
>> > +    <height>334</height>
>> 
>> Is that relevant? Intentional? Caused by a different version of the
>> tool? A bug?
>
> That happens if he expanded the window to work on it. But it does change the 
> default size...

Ok, easy enough to filter out.

>> >    <property name="currentIndex">
>> > 
>> > -   <number>0</number>
>> > +   <number>3</number>
>> > 
>> >    </property>
>> 
>> How about this one? A number changes from 0 to 3. No mention of it in
>> the commit message...
>
> This is also probably the result of saving the file after exploring the UI.
>
> However, it's also changing which tab is presented by default. This change 
> should not be done, unless it was intentional.

Eh - unlikely at this stage.

>> Maybe we need a sub-maintainer (clearly one of the people doing the
>> majority of the work on the Qt UI) who simply owns the UI and gets to be
>> the one to make sure changes like this are sane and make sense?
>
> I'd recommend reading the diff just to make sure that some of the defaults 
> weren't changed unnecessarily. The size isn't a big deal, since the window 
> will be resized to fit the contents. But changing the default tab might be a 
> bad idea.

I usually try to read all diffs before committing things - but I have
frequently proven to be too quick with the trigger finger (thankfully
git makes that relatively harmless - but you'll find plenty of 'oops' in
the git log).

>> How do other projects handle this, Thiago?
>
> I would recommend git add -p and avoid unnecessary changes whenever possible. 
> You don't need to split your head open to make a nice XML change if Designer 
> changed a lot, but simple changes should be doable.

So this is something that the SUBMITTER of the patch should do (to make
my life easier) :-)

I'll apply this one after filtering out the two unintended changes.

Thanks

/D