Build problem?

[Thiago Macieira]

On segunda-feira, 8 de abril de 2013 21.15.21, Amit Chaudhuri wrote:
> qt-ui/mainwindow.h:23:8: error: expected ‘:’ before ‘slots’
> qt-ui/mainwindow.h:23:8: error: ‘slots’ does not name a type
> make: *** [qt-gui.o] Error 1
> amit at linux-erag:~/subsurface>
> 
> Somehow I think the rules need to ensure that the mainwindow moc-ing happens
> before the attempt to include in qt-gui...

This error is not caused by the moc output.

We have this in the Makefile:

CXXFLAGS=-Wall -g $(CLCFLAGS) -fPIC -DQT_NO_KEYWORDS

commit b5b14f1d95b0362a13fa3f11ac3f334012750099
Author: Alberto Mardegan <mardy at users.sourceforge.net>
Date:   Mon Apr 1 23:03:47 2013 +0300

    Define QT_NO_KEYWORDS
    
    This prevents Qt headers from defining macro symbols such as "emit" and
    "signals", therefore avoiding conflicts when struct members with the
    same names are defined in some C header.
    
    Signed-off-by: Alberto Mardegan <mardy at users.sourceforge.net>


You'll need to write Q_SLOTS instead of slots.

I'd like to drop that macro. It makes the code uglier in my opinion. Alberto, 
did you find any conflicts?

-- 
Thiago Macieira - thiago (AT) macieira.info - thiago (AT) kde.org
   Software Architect - Intel Open Source Technology Center
      PGP/GPG: 0x6EF45358; fingerprint:
      E067 918B B660 DBD1 105C  966C 33F5 F005 6EF4 5358
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 190 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.hohndel.org/pipermail/subsurface/attachments/20130408/fe431080/attachment.sig>