Build problem?

[Michael Hasselmann]

On Tue, 2013-04-09 at 15:35 +0400, Alberto Mardegan wrote:
> On 04/09/2013 12:48 AM, Thiago Macieira wrote:
> > You'll need to write Q_SLOTS instead of slots.
> >
> > I'd like to drop that macro. It makes the code uglier in my opinion. Alberto,
> > did you find any conflicts?
> 
> Please don't drop it :-)
> I found a conflict with the "signals" name. Both in subversion and in 
> another project of mine (libaccounts-qt, which wraps a glib library).
> 
> GDBus's gdbusintrospection.h has a struct with a member named "signals".
> 
> After finding that, I got used to the uppercase macros, and I actually 
> like them better than the lowercase keywords. :-)

Fully agree with Alberto here. Actually, I'd go even further: Q_EMIT,
Q_FOREACH … just to make it very clear that you are now using C++
language extensions provided by Qt. Remember that this code will have to
be read by non-Qt/non-C++ experts, too. I'd think they'd welcome the
extra clarity.

ciao Michael