[PATCH] Simplify dive tag checkbox code

Linus Torvalds torvalds at linux-foundation.org
Wed Apr 10 07:18:40 PDT 2013


On Wed, Apr 10, 2013 at 1:24 AM,  <subsurface at henrik.synth.no> wrote:
> From: Henrik Brautaset Aronsen <subsurface at henrik.synth.no>
>
> Getting rid of duplicated code when generating gtk check buttons.

Good..

> +       checkbox_tag(button, sbox, dive, DTAG_BOAT, _("Boat"));
> +       checkbox_tag(button, sbox, dive, DTAG_SHORE, _("Shore"));
..

Could we please also use the tag-name array? That way you could just
do this all in a loop, but it would *also* avoid the need for
unnecessary translations.

Sure, if people are married to the capitalization differences, that
doesn't work, but are people? Or would people be ok with doing
programmatic capitalization (for ASCII only?)

               Linus


More information about the subsurface mailing list