Tags are only shown if they are identical for all edited dives

Linus Torvalds torvalds at linux-foundation.org
Wed Apr 10 12:21:08 PDT 2013


On Wed, Apr 10, 2013 at 11:47 AM, Henrik Brautaset Aronsen
<subsurface at henrik.synth.no> wrote:
>
> Looks good.  But we would maybe need to display the partially selected tag,
> no?  I've seen similar tri-state checkboxes: selected (checked), unselected
> (unchecked) and partially selected (checked, but in grey).

Why?

Everything else we do, we show and edit the master dive data. There is
no "partially selected" data, exactly the same way there is no
"partially same location". When we edit the location of a dive, we
look at, and edit, the master dive location. Then, if other dives
matched the old location (or had no location information at all), we
update other dives too, but we very much have that concept of "master
dive", which is what we really fundamentally are editing. The other
selected dives are always about "ok, we *may* change them too, when
the old dive state made sense".

               Linus


More information about the subsurface mailing list