[PATCH] Add dive list view to main window

[Dirk Hohndel]

Amit Chaudhuri <amit.k.chaudhuri at gmail.com> writes:
>
> thanks for the comments on the coding style.  Some of this is new-ish to me
> so apologies for any wayward tendencies.  It'll sink in soon enough.  I'll
> revise and send a later.  Might be in the morning.

No problem. I think that Lubomir is right, though. We should all try to
figure out the style we want to use right now and then try as much as
possible to stick with it.

I can still tell in parts of the existing C code when I took patches
that I should have sent back for coding style issues but didn't because
I didn't want to be too much of a pain to new contributors... it always
comes back to bite you.

> I'd be interested in Thiago's thoughts on pointers vs. const references and
> static_cast vs C cast.  The usage in the patch follows the styles I see in
> Qt code examples.  Doesn't necessarily mean alternatives are bad.  Thiago?

Wait... I'm getting some popcorn...

I was an amused audience member seeing Thiago and Linus discuss this in
the past. This is going to be good... :-)

> And for the record, it is "hear, hear" - something to do with listening to
> the speaker.....I didn't know that - so I looked it up.  Learn something
> every day..

I thought it was about listening, too, but I see "here, here" so often.

But then you see "its wrong" when people wanted to write "it's wrong"
all the time. That doesn't make it right :-)

/D