[PATCH] Add dive list view to main window

[Dirk Hohndel]

Amit Chaudhuri <amit.k.chaudhuri at gmail.com> writes:

> Revised patch has gone in which [I think] fixes most of the format issues.

Well, it has consistent '4 space' indentation. I really want tab based
indentation (and a tab is 8-wide, not 4-wide).

> I've not changed references to pointers and I've gone with mPrefix style as
> I think that's what we agreed a few days back.  Now I'm not so sure, so
> I'll watch the traffic overnight and will change if that's the consensus.

I believe the decision was no 'm' prefix at all.

The confusion on my part had been that I was arguing against using
underscores mixed with camelCase names. And completely missed the fact
that people were actually talking about the 'm_' (or just 'm') prefix on
local variables.

I think prefixes for local variables are kind of silly and just make the
code harder to read.

On the references vs. pointers thing I'll wait for more input from
Thiago :-)

/D