[PATCH] Add dive list view to main window

[Dirk Hohndel]

Amit Chaudhuri <amit.k.chaudhuri at gmail.com> writes:

> m prefix is not on local variables.  I agree that would be odd.  The
> distinction being made with m (or m_ or _) is to mark private members
> variables. 

Sorry. Private members are just local variables to that structure...

> It's quite common in C++ stuff I believe.  But different people make
> different calls.  I'm not fussed either way.  Maybe such a mixed case
> we should drop it completely.

I think we are mostly trying to stay sane and somewhat self-consistent
here. And the majority of contributors (the people who write 80+% of the
code so far :-) ) are first and foremost C developers who are doing the
whole C++ thing because that's the price for getting a better UI
toolkit.

> On the 4/8 space/tab thing, the editor used shows them as tabs (and that is
> the input) so I'm not sure what's behind that.  Have my previous patches
> had tab correctly? If so, I'm temporarily stumped.

I haven't noticed this as a problem lately. I know that your first
couple of patches had serious white space issues, but later I thought
they were mostly ok. I could go back and check in the archives... :-)

/D