Simplistig tag filtering

[Dirk Hohndel]

On Apr 21, 2013, at 8:26 PM, Miika Turkia wrote:

> On Mon, Apr 22, 2013 at 3:59 AM, Dirk Hohndel <dirk at hohndel.org> wrote:
> 
> I'm thinking about doing a 3.1 release and was going through the changes
> 
> Translations will require some work. At least the explanation for dive planning has been changed and translations for it are not used (as they are for the old wording). And I believe there are a couple of new strings that need to be included in the translations as well.

Oh there are quite a few. I was planning to push what we have right now to Transifex tonight or tomorrow.

> I sent a patch for importing Suunto DM4 dives from XML format (exported one by one from DM4) a couple of days ago (Apr 13). Should I resend or are they in your backlog?

Oops - I didn't realize I had a backlog. In general, if I don't respond to patches within 48h - resend :-)

> that we have and realized that right now the tags were of excessively
> limited use. So to have at least one half assed use case I did a quick
> and dirty implementation of a "filter by tag". The filter isn't retained
> after you exit and the filter only supports an "AND" operation, i.e.,
> only dives that have ALL of the tags that you select (but possibly more
> than those) will be shown.
> 
> The 'invalid' tag is of course now handled twice and in a mildly
> inconsistent fashion. But I think it's not too bad.
> 
> Was there other use case for the invalid tag than freedive?  Would it make sense to change it to use name freedive instead?

As it happens there are other uses. Some dive computer apparently can get into error modes and create bogus dives (see the report for Uemis we just got). So I think the idea behind "invalid" is, err, valid :-)

> Please take a look, this was pushed to master.
> 
> First impression is positive. However, the "random" order of the tags is a bit hard to grasp. Ordered by alphabet would be easier to search for tags.

Then 'boat' and 'shore' aren't next to each other. And invalid isn't first. Right now they are kinda-sorta grouped (actually, they were and then I added some to the end).
I really rather would have them grouped a bit more logically then just alphabetically. Especially as this gets tricky when you think about other locales...

> A button to clear selection might be useful?

That I agree with.

Patches? :-)

/D