[patch] Use subsurface integer units for dive item
Tomaz Canabrava
tcanabrava at kde.org
Tue Apr 23 06:36:37 PDT 2013
Uip, they were merged on models.h / .cpp , Dirk asked us to not make a
file-for-class and keep code almost like the C code.
2013/4/23 Henrik Brautaset Aronsen <subsurface at henrik.synth.no>
> Np. Also, you should make sure you base your stuff on the latest code, as
> I see that divetripmodel.h|cpp was recently removed:
> https://github.com/torvalds/**subsurface/commit/**
> a0280ae7d2cdd483bc53c7bc91a8aa**438f9234de<https://github.com/torvalds/subsurface/commit/a0280ae7d2cdd483bc53c7bc91a8aa438f9234de>
>
> Cheers,
> Henrik
>
> Amit Chaudhuri wrote:
>
>> Henrik - Ok - thanks for the quick pointer. I'll modify to use tr() and
>> re-post.
>>
>>
>> On Tue, Apr 23, 2013 at 9:00 AM, Henrik Brautaset Aronsen <
>> subsurface at henrik.synth.no <mailto:subsurface at henrik.**synth.no<subsurface at henrik.synth.no>>>
>> wrote:
>>
>> Hi Amit.
>>
>> The Qtr_ hack was removed in an earlier commit 9 days ago. You
>> might have been basing your work on an old branch?
>>
>> See
>> https://github.com/torvalds/**subsurface/commit/**
>> d8e11439ad27063b0dad05b2f8f0f4**cd7f3e7de1<https://github.com/torvalds/subsurface/commit/d8e11439ad27063b0dad05b2f8f0f4cd7f3e7de1>
>>
>> Henrik
>>
>> Amit Chaudhuri wrote:
>>
>> Hi Dirk,
>>
>> This patch swaps float for int in DiveItem to better align
>> with subsurface.
>>
>> I also swapped tr() for Qtr_() to support the translations at
>> the end of
>> the process. This last step prevents compilation I think
>> because Qtr_ is
>> declared in qt-ui/common.h which I think is missing from
>> origin/Qt. But
>> I could be wrong. I've had some odd stuff going on in another
>> branch.
>>
>> If my assumption is wrong, please bounce the patch and I'll
>> correct.
>>
>> A
>>
>> ______________________________**_________________
>> subsurface mailing list
>> subsurface at hohndel.org <mailto:subsurface at hohndel.org**>
>> http://lists.hohndel.org/cgi-**bin/mailman/listinfo/**subsurface<http://lists.hohndel.org/cgi-bin/mailman/listinfo/subsurface>
>>
>>
>>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.hohndel.org/pipermail/subsurface/attachments/20130423/dca66dda/attachment.html>
More information about the subsurface
mailing list