[PATCH] Remove useless members of DiveItem

Linus Torvalds torvalds at linux-foundation.org
Thu Apr 25 08:25:54 PDT 2013


On Thu, Apr 25, 2013 at 8:15 AM, Dirk Hohndel <dirk at hohndel.org> wrote:
>
> I'll be in the office in an hour (once I'm off this call I'll drive
> out). Let's have coffee and I'll share some of the more brilliant
> features of the Gtk TreeViewModel disaster with you :-)

Hey, to be fair, I think you can do similar things in GtkTreeView by
specifying your own renderer for each column. I don't *think* you
necessarily have to have a 1:1 relationship between treeview columns
and tree models. So *maybe* we could have made the tree model just
contain the pointer to the dive (or the dive index), and not had all
those individual fields there, and then just built up the tree view
columns and have a renderer that looked up the data for each of them.

So the reason we did it like we did in the gtk version was that all
the cell renderer and treeview stuff is %$#! confusing, and I started
out without specialty renderers. I'm not sure it's the only way to do
it, though.

                      Linus


More information about the subsurface mailing list