[PATCH] Remove useless members of DiveItem

Linus Torvalds torvalds at linux-foundation.org
Thu Apr 25 08:50:16 PDT 2013


On Thu, Apr 25, 2013 at 8:46 AM, Thiago Macieira <thiago at macieira.org> wrote:
>
> Right. The model needs to be told anyway because the model will need to tell
> the view (the UI) that something changed. If the dives could change without
> notifying the UI, it could keep on happily displaying old data and then lead
> to weird conditions later on.

As long as Qt won't continue to use the data, I guess that's fine. The
thing that worried me was things like queued updates in the event
structures etc. The main loop of GUI stuff tends to have various
queued stuff, but if it's safe to delete view elements at any time,
then that's fine.

                Linus


More information about the subsurface mailing list