Patch - Show Stars on the DiveList model
Dirk Hohndel
dirk at hohndel.org
Sun Apr 28 13:13:03 PDT 2013
Ok, found it and pushed it. Looks awesome.
Playing with the UI I ran into a fun little bug. You sort the columns
alphabetically, even if the values are numeric. Sort by depth (ft/m) for
example and you'll see what I meant "-)
/D
On Sun, 2013-04-28 at 08:47 -0300, Tomaz Canabrava wrote:
> Ups.
>
>
> I put the code on the file_open callback, when you open a file via
> command line this doesn't get called.
>
> Updated the code with the fix ( plus a micro-fix to Qt4 - only for
> better sorting ).
>
> Same branch - RenderStarsOnTable, Merge it when you woke up ^^
>
> Tomaz
>
>
>
> 2013/4/28 Dirk Hohndel <dirk at hohndel.org>
> On Sat, 2013-04-27 at 13:11 -0300, Tomaz Canabrava wrote:
> > The following changes since commit
> > 1d0d42f861fc3a658eb22b99ba58616d716e095e:
> >
> > Remove the explicit UTF-8 conversions (2013-04-25 21:10:05
> -0700)
> >
> > are available in the git repository at:
> >
> > https://github.com/tcanabrava/subsurface.git
> RenderStarsOnTable
> >
> > for you to fetch changes up to
> > 2f4d6bbe535a195046b4746fd3a771087ee4a6c4:
>
>
> Perfect pull request. Thank you.
>
> > Added support for showing the Stars on the DiveTable
>
>
> Not sure if this is a Qt4 issue or if something else went
> wrong, but my
> dive table (we call it dive list, usually) doesn't show stars
> - it shows
> the numbers 0 through 5...
>
> I'll push what I have but maybe you could take a look why this
> isn't
> working as you are describing it?
>
> Thanks
>
> /D
>
>
>
>
>
More information about the subsurface
mailing list