[PATCH] Identify below floor event type properly.

Dirk Hohndel dirk at hohndel.org
Thu Aug 8 10:56:10 UTC 2013


On Thu, 2013-08-08 at 12:34 +0200, Michael Andreen wrote:
> Hi,
> 
> On Saturday 27 July 2013 08:30:48 Dirk Hohndel wrote:
> > On Jul 27, 2013, at 2:29 AM, Michael Andreen wrote:
> > > That was what I was trying to a discussion about with my first mail.
> > > Currently type 16 is only used for this specific event in
> > > libdivecomputer, so renaming it means old dives will have the right type
> > > id, making it easy to update the text later, and subsurface can be
> > > updated independently of libdivecomputer.
> > > 
> > > I guess it's mainly Jef's call. I sent the companion patch to the
> > > libdivecomputer list.
> > 
> > Jef is traveling. I'll wait for him to decide how he wants this solved
> > before applying the patch.
> 
> Hi, any chance of this getting in now that libdivecomputer has been updated?

I'm trying not to be too super aggressive to give people a chance to
have their build not break :-)
(I have been very aggressive like this in the past and people didn't
love being forced to upgrade to the latest devel version of
libdivecomputer when they pull the latest Subsurface)

But yes, I'll add it soon.

/D



More information about the subsurface mailing list