Multi Dive Edition - Path

[Tomaz Canabrava]

Miika,

The visual glitch that you showed on the print should be fixed by a patch
that I send a few days ago ( trip selection then dive selection messes up
the layout), I'll try here again to see if I messed anything up in that
regard.

About the equipments, I didn't realized that they where also part of the
multi edition, will update the diff.

What graph information doesn't get updated when you hover it? ( just woke
up. )

And, from the diff, multi dive editing will change every dive marked as
'selected', so it can't mark one above.

Sleep, just woken, Tomaz
 Em 17/08/2013 06:05, "Miika Turkia" <miika.turkia at gmail.com> escreveu:

> Hola,
>
> this seems like a good start. I have only done a basic test with my newest
> donwload, but whatever is in the Dive Notes tab seems to be working (at
> least with the new dives). However, I think it is this patch that messes up
> the screen layout on the Dive Notes tab, see the attachment. Also the dive
> information when one hovers over the graph is not updating. I am pretty
> sure it worked before this patch. (I need to keep mouse button pressed or
> click on the graph to get the info updated. I can live with both ways but
> if the change was un-intentional...)
>
> Visual feedback is lacking when on multi-dive editing mode, text talks
> about single dive editing and there should be something that stands out
> when on multi-dive editing mode. At least the text could say: Editing dives
> 10-13,14,... or Editing 4 dives. I think there was also some discussion
> regarding multi-dive editing and how to overwrite and not overwrite
> existing information when the same feature was implemented in Gtk version.
> That should discussion be dug out as there were many good points to take
> into account.
>
> Multi-dive editing should be also expanded to the equipment tab, allowing
> one to set the size of the cylinder and configuring the weight system.
>
> Now that I am also looking at git diff, it seems that the multi-dive
> editing touches an extra dive on top of the selection. However, when trying
> to replicate this, it does not occur again. I will keep my eyes open if
> this was me messing around or a bug in Subsurface.
>
> miika
>
>
>
> On Sat, Aug 17, 2013 at 1:09 AM, Tomaz Canabrava <tcanabrava at kde.org>wrote:
>
>> ➜  subsurface git:(multiDiveEdition) ✗ git request-pull origin origin
>> multiDiveEdition
>> The following changes since commit
>> 16addbf373d138819411540a5be49513d58a4038:
>>
>>   Use maxx from graphics context for time calculation. (2013-08-08
>> 20:00:15 +0200)
>>
>> are available in the git repository at:
>>
>>   https://github.com/tcanabrava/subsurface multiDiveEdition
>>
>> for you to fetch changes up to 2b6c3b4c0cb094a06bc832573f68be00de9d7293:
>>
>>   Good deal of code cleanup. (2013-08-16 15:52:40 -0300)
>>
>> ----------------------------------------------------------------
>> Dirk Hohndel (1):
>>       Compile fix
>>
>> Tomaz Canabrava (4):
>>       Fix for double-rendering, double selection and other annoyances.
>>       Enable Multi Dive Editing.
>>       Change bg of edited parts of the dive on the interface
>>       Good deal of code cleanup.
>>
>>
>> _______________________________________________
>> subsurface mailing list
>> subsurface at hohndel.org
>> http://lists.hohndel.org/cgi-bin/mailman/listinfo/subsurface
>>
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.hohndel.org/pipermail/subsurface/attachments/20130817/680a2962/attachment.html>