[PATCH] fix the DownloadDialog canceling behavior

Danilo Cesar Lemes de Paula danilo.eu at gmail.com
Thu Aug 29 16:04:09 UTC 2013


Guys,

I decided to use github to store my branches so I'm sending a
pull-request with my current patches. Hope it's OK.

The following changes since commit 2fb2918607ffb857543b9060fd9f18f0d07ab780:

  Compile fix (2013-08-13 20:29:22 +0200)

are available in the git repository at:

  git at github.com:danilocesar/subsurface.git bugfixes

for you to fetch changes up to ab649e21ba07c9f572d61350b9217609f44f7f04:

  fix DownloadDialog behavior (2013-08-29 19:20:34 -0300)

----------------------------------------------------------------
Danilo Cesar Lemes de Paula (3):
      use QWebView to show the user manual
      fixing planner's gas dialog
      fix DownloadDialog behavior

 Configure.mk                       |  2 +-
 qt-ui/diveplanner.cpp              |  5 +++--
 qt-ui/downloadfromdivecomputer.cpp | 42
+++++++++++++++++++++++++++++++++++++++++-
 qt-ui/downloadfromdivecomputer.h   |  9 ++++++++-
 qt-ui/mainwindow.cpp               |  8 ++++----
 qt-ui/mainwindow.h                 |  4 ++--
 6 files changed, 59 insertions(+), 11 deletions(-)



On 08/25/2013 10:16 AM, Danilo Cesar Lemes de Paula wrote:
> After Jef's explanation about how libdivingcomputer is suppose to deal
> with downloads I've rewrote this patch.
> 
> basically if fixs the situation where the UI components are accessible
> during the download AND the DownloadWidget can be closed (by pressing
> escape) during a download.
> 
> I'm cooking another patch here to avoid the QMainThread to be blocked by
> waiting the downloadThread to finish. Should be done soon.
> 
> 
> --
> Danilo Cesar
> 



More information about the subsurface mailing list