[PATCH] Move dive notes edit message above the scrollable widget

Lubomir I. Ivanov neolit123 at gmail.com
Tue Dec 3 12:19:57 UTC 2013


On 3 December 2013 22:16, Lubomir I. Ivanov <neolit123 at gmail.com> wrote:
> On 3 December 2013 22:03, Dirk Hohndel <dirk at hohndel.org> wrote:
>> On Tue, 2013-12-03 at 20:56 +0100, Henrik Brautaset Aronsen wrote:
>>> Lubomir I. Ivanov wrote:
>>> > On 3 December 2013 21:46, Tomaz Canabrava <tcanabrava at kde.org> wrote:
>>> > > Lubomir, there's the same message for the EquipmentTab, if you move one can
>>> > > you move the other too?
>>> > >
>>> > >
>>> >
>>> > i think i didn't understand what hernik patch does.
>>> > what i would suggest is to have only one "message"/"save"/"cancel"
>>> > field on top of main tab while editing (or N of count if needed that
>>> > do the same), and such a filed will not affected by scrolling?
>>> > this will assure that the user can exit "edit mode" at any time on
>>> > smaller displays.
>>>
>>> I only fixed the message display on the Dive Notes.  I can do the same
>>> thing on the equipment tab.
>>
>> Please do.
>>
>>>  It needs to be added on the two remaining tabs as well...
>>
>> Not really, the two remaining tabs just provide statistical data,
>> nothing you can edit. We already have the triangle in the tab headers to
>> show that there is editing going on...
>>
>
> but perhaps the "save"/"cancel" can be always in one instance there
> like tomaz said, earlier?
> sounds sane, programming wise as we are going to maintain one instance.
>
> as far as the static tabs go, and example would be:
> - someone edits
> - goes to the stats tab
> - wants to save and presses a button "save" on top instead of going
> back to the editable tabs?
>

gosh...lack of sleep is proportional to bad english syntax...

lubomir
--


More information about the subsurface mailing list