ideas for tasks before christmas

Dirk Hohndel dirk at hohndel.org
Tue Dec 3 14:15:00 UTC 2013


On Wed, 2013-12-04 at 00:08 +0200, Lubomir I. Ivanov wrote:
> >> > tomaz, thiago, dirk, linus,
> >>
> >> thiago, if you are way busy with you work, i can perhaps also suggest
> >> finishing the netcode you are working on right now for the
> >> webservices?
> >> i have experience with that in platforms other than Qt, but i can
> >> perhaps get it to work, without much ML questions...
> >
> > Hi Lubomir
> >
> > The network code itself is done. You can find it at
> > git://github.com/thiagomacieira/subsurface.git on branch improve-
> > subsurfaceweb. I've just rebased it.
> >
> > However, it's missing three things before we can integrate it:
> >  - confirm that the downloaded dives from hohndel.org are getting integrated
> >    properly into the dive list (fix it if not)
> >  - write the code that merges the downloaded dives from divelogs.de
> >  - write the code that generates the data to be uploaded to divelogs.de
> >
> > The Gtk version had support for uploading, so you should be able to extract
> > from the old version the code to create a .zip file to be posted. Once the .zip
> > file is created, the code I wrote should already work (but is untested).
> >
> 
> i can certainly look into that!
> one major trouble i had is related to the "cancel" button, as:
> QNetworkReply::abort() will create sort of a "race", because we are
> lazy de-allocating the last reply with "delateLater()".
> 
> the idea of the "cancel" button is to stop the download/connection
> completely and not update the divelist if there is success, to my
> understanding.
> 
> if we can perhaps "delete reply" immediately in "finished" (and
> "error") then this would not be a problem, but i was still getting
> crashes in abort() when i tested.
> maybe i have it all wrong, or you have solved it, Qt wise?

We have problems with deleteLater() crashing elsewhere in the code as
well... to the point where we commented out some of those calls...

/D



More information about the subsurface mailing list