Sume help regarding the Add Dive diveplan creation.

Dirk Hohndel dirk at hohndel.org
Tue Dec 3 20:57:01 UTC 2013


Bisected this to a fairly old commit of mine where I rewrote code in a
much more obvious manner - and missed a '-1'. Classic off by one error.

Sorry for causing you to waste time. Fixed and pushed.

/D

On Tue, 2013-12-03 at 23:46 -0200, Tomaz Canabrava wrote:
> Btw - this should be tested after applying my two other patches for
> today - because if you don't, there are crashes.
> 
> 
> 
> On Tue, Dec 3, 2013 at 11:20 PM, Tomaz Canabrava <tcanabrava at kde.org>
> wrote:
>         People,
>         
>         
>         I was trying to debug the strange bug that happens when you:
>         
>         1 - create a new dive from the dive - plan dialog ( accept the
>         default, works )
>         
>         2 - things get correctly plotted on the profile - good.
>         
>         3 - click on 'edit' on the scene button ( the penguin )
>         
>         4 - the profile gets correctly plotted but the time - ruler
>         'maximum' is 30 ( instead of the 50 that it should be. )
>         
>         
>         I'v tracked it down to 
>         
>             while(dp->next){
>                 dp = dp->next;
>             }
>         
>         
>         The result of qDebug() << dp->time is as follows
>         5 
>         11.55 
>         50.55 
>         49.2167  
>         52.2167 
>         5 
>         
>         
>         ( the 5 in the beginning and in the end )
>         
>         I'v checked the code that loads the data from the Dive and it
>         seemed right ( no wrong values on the DivePlannerModel. )
>         
>         
>         the code that creates the wrong and faulty diveplan:
>         
>         diveplanner.cpp line 483 
>         
>         I'd appreciate some help, a bit lost ( and it's almost
>         midnight )
>         
>         
>         
>         Tomaaz
>         
> 
> 
> _______________________________________________
> subsurface mailing list
> subsurface at hohndel.org
> http://lists.hohndel.org/cgi-bin/mailman/listinfo/subsurface




More information about the subsurface mailing list