[PATCH] Divelist: fix a crash when updating the preferences
Anton Lundin
glance at acc.umu.se
Wed Dec 4 09:37:22 UTC 2013
On 04 December, 2013 - Lubomir I. Ivanov wrote:
> From: "Lubomir I. Ivanov" <neolit123 at gmail.com>
>
> Hitting apply in the preferences dialog causes a QList assert.
> This led to DiveListView::reloadHeaderActions(), where
> we have an out of range access.
>
> Patch makes the column count match the header action count.
>
> Signed-off-by: Lubomir I. Ivanov <neolit123 at gmail.com>
> ---
> not sure how no one has caught this bug, perhaps the assert only triggers on
> win32. i've CCed the original author for comments, since i don't think
> i understand why we need to skip the first element?
>
I started to hit this one to a day or to ago, so some assumption isn't
true anymore.
I can confirm that this patch fixes it for me too.
//Anton
--
Anton Lundin +46702-161604
More information about the subsurface
mailing list