[PATCH] Divelist: fix a crash when updating the preferences

Tomaz Canabrava tcanabrava at kde.org
Wed Dec 4 09:51:07 UTC 2013


It seems right, I'm retarded. :)


On Wed, Dec 4, 2013 at 3:37 PM, Anton Lundin <glance at acc.umu.se> wrote:

> On 04 December, 2013 - Lubomir I. Ivanov wrote:
>
> > From: "Lubomir I. Ivanov" <neolit123 at gmail.com>
> >
> > Hitting apply in the preferences dialog causes a QList assert.
> > This led to DiveListView::reloadHeaderActions(), where
> > we have an out of range access.
> >
> > Patch makes the column count match the header action count.
> >
> > Signed-off-by: Lubomir I. Ivanov <neolit123 at gmail.com>
> > ---
> > not sure how no one has caught this bug, perhaps the assert only
> triggers on
> > win32. i've CCed the original author for comments, since i don't think
> > i understand why we need to skip the first element?
> >
>
> I started to hit this one to a day or to ago, so some assumption isn't
> true anymore.
>
> I can confirm that this patch fixes it for me too.
>
> //Anton
>
> --
> Anton Lundin    +46702-161604
> _______________________________________________
> subsurface mailing list
> subsurface at hohndel.org
> http://lists.hohndel.org/cgi-bin/mailman/listinfo/subsurface
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.hohndel.org/pipermail/subsurface/attachments/20131204/8b127dcf/attachment.html>


More information about the subsurface mailing list