ideas for tasks before christmas

Lubomir I. Ivanov neolit123 at gmail.com
Wed Dec 4 12:20:48 UTC 2013


On 4 December 2013 04:21, Thiago Macieira <thiago at macieira.org> wrote:
> On quarta-feira, 4 de dezembro de 2013 00:08:56, Lubomir I. Ivanov wrote:
>> i can certainly look into that!
>> one major trouble i had is related to the "cancel" button, as:
>> QNetworkReply::abort() will create sort of a "race", because we are
>> lazy de-allocating the last reply with "delateLater()".
>>
>> the idea of the "cancel" button is to stop the download/connection
>> completely and not update the divelist if there is success, to my
>> understanding.
>>
>> if we can perhaps "delete reply" immediately in "finished" (and
>> "error") then this would not be a problem, but i was still getting
>> crashes in abort() when i tested.
>> maybe i have it all wrong, or you have solved it, Qt wise?
>
> Please check the code in my branch first. I might have fixed the issue already.
> --

i can't make it crash any more by pressing cancel, and also the buttom
seems to abort the download now (if i tested that correctly).
here is small fix i had to do on win32, you can ignore the patch if
you prefer to make the change yourself.

lubomir
--
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Webservices-fix-QString-argument-for-zip_open.patch
Type: application/octet-stream
Size: 876 bytes
Desc: not available
URL: <http://lists.hohndel.org/pipermail/subsurface/attachments/20131204/685204f4/attachment.obj>


More information about the subsurface mailing list