[PATCH 1/2] Fix compilation with older libzip

Thiago Macieira thiago at macieira.org
Thu Dec 5 23:16:51 UTC 2013


On quinta-feira, 5 de dezembro de 2013 20:18:17, Thiago Macieira wrote:
> On quinta-feira, 5 de dezembro de 2013 20:08:20, Dirk Hohndel wrote:
> > > -       quint64 entries = zip_get_num_entries(zip, 0);
> > > +       quint64 entries = zip_get_num_entries(zip, (zip_flags_t)0);
> > 
> > Nope. that doesn't work on 64bit Linux.
> > 
> > Basically we have platforms where the real type in zip.h is 32bit and
> > others where it is 64bit. So I think we can't use the trick that you
> > propose.
> > 
> > I'll revert that patch of yours, sorry.
> 
> I've got another trick up my sleeve.

Didn't work.

The same solution I added to Qt's src/corelib/kernel/qcore_unix_p.h to get 
pipe2, dup3 and accept4.

I wonder if my 4+ year old solution is actually wrong...
	https://qt.gitorious.org/qt/qt/commit/6d9143eb

-- 
Thiago Macieira - thiago (AT) macieira.info - thiago (AT) kde.org
   Software Architect - Intel Open Source Technology Center
      PGP/GPG: 0x6EF45358; fingerprint:
      E067 918B B660 DBD1 105C  966C 33F5 F005 6EF4 5358
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 190 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.hohndel.org/pipermail/subsurface/attachments/20131205/394fdd8a/attachment.sig>


More information about the subsurface mailing list