[PATCH] Cleanup some uninitialized variables
dirk at hohndel.org
Sat Dec 7 07:34:46 UTC 2013
On Sat, 2013-12-07 at 16:08 +0100, Anton Lundin wrote:
> On 05 December, 2013 - Dirk Hohndel wrote:
> > On Thu, 2013-12-05 at 11:33 +0200, Lubomir I. Ivanov wrote:
> > > On 5 December 2013 01:48, Anton Lundin <glance at acc.umu.se> wrote:
> > > > I can't really see any point in passing a local loop variable around,
> > > > and copying a uninitialized pointer. Better use local variables there
> > > > and let the compiler optimize them away if it feels for doing that.
> > >
> > > it's an old trick to complicate interfaces.
> > >
> > > your change will definitely optimize the loop.
> > > (missing signed-off-by)
> > Dang, I missed that :-(
> Wops. I can gift that code to Dirk who added his sob to the commit, as a
> early christmas gift =)
When I add patches (instead of pulling from other trees) I always sign
them off as the committer. And usually I notice when the author forgot
the SOB and ask them... but sometimes that slips through :-/
More information about the subsurface