[PULL REQUEST] fix the divelogs.de upload

[Dirk Hohndel]

OK, one more idea for improvement (but I'll push this as is, don't want
to mess with things that I pulled from you):

fprintf(stderr,...) is odd to do from C++ - have you considered using
qDebug()?

Thanks for your work on this code. Much appreciated

/D

On Mon, 2013-12-09 at 17:56 +0200, Lubomir I. Ivanov wrote:
> these series fix the divelogs.de upload. thanks to sergey starosek
> for spotting the missing 'filename' field.
> 
> on win32 i'm getting some memory corruption. prepare_dives_for_divelogs() is
> based on the GTK code miiaka wrote (if i remember correctly) and it has a
> local variable named 'tempfile'. now, everything is fine, however at one point
> get_stylesheet() changes the contents of the local variable
> 'tempfile', which isn't a good sign. i suspect buffer overflow in parse-xml.c:
> get_stylesheet()/try_get_stylesheet(), but i haven't investigated that.
> 
> the patches are a bit of a mess, so if something has to be changed, please
> let me know.
> 
> ----------------------------------------------------------------
> The following changes since commit 3a49ad6ba5e8634e8653a60b5be3a75f2bc79959:
> 
>   Update to manual (2013-12-09 13:54:11 +0100)
> 
> are available in the git repository at:
> 
>   git at github.com:neolit123/subsurface.git web
> 
> for you to fetch changes up to 04b62a46e9f28f0e3b4a4f2e3c3aa9c18445df2f:
> 
>   Divelogs.de: attempt to impletent 'Cancel' properly (2013-12-09 17:42:06 +0200)
> 
> ----------------------------------------------------------------
> Lubomir I. Ivanov (10):
>       Divelogs.de: allow import of downloaded dives
>       Divelogs.de: add a divelist context menu item for upload
>       Divelogs.de: add code for zipping up all dives
>       Divelogs.de: parse response once the upload is finished
>       Divelogs.de: improve prepare_dives_for_divelogs()
>       Divelogs.de: further improve reading the server reponse
>       Divelogs.de: Add a 'filename' field when uploading
>       Divelogs.de: Improve the error handling post DLD creation
>       Divelogs.de: store the user/pass on upload
>       Divelogs.de: attempt to impletent 'Cancel' properly
> 
>  qt-ui/divelistview.cpp          |   8 ++
>  qt-ui/divelistview.h            |   1 +
>  qt-ui/subsurfacewebservices.cpp | 194 ++++++++++++++++++++++++++++++++++++----
>  qt-ui/subsurfacewebservices.h   |   3 +-
>  4 files changed, 186 insertions(+), 20 deletions(-)
> _______________________________________________
> subsurface mailing list
> subsurface at hohndel.org
> http://lists.hohndel.org/cgi-bin/mailman/listinfo/subsurface