[PATCH 8/9] Make the streamsize variable actually int

Thiago Macieira thiago at macieira.org
Wed Dec 11 17:56:34 UTC 2013


Casting a pointer to a size_t variable to a pointer to int is wrong on
big endian machines. Not that I expect anyone to compile Subsurface 4
for Mac on PowerPC 64-bit, but just in case... Who knows, we may have
some Solaris-on-UltraSPARC or AIX-on-POWER6 users.

Signed-off-by: Thiago Macieira <thiago at macieira.org>
---
 qt-ui/subsurfacewebservices.cpp | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/qt-ui/subsurfacewebservices.cpp b/qt-ui/subsurfacewebservices.cpp
index 5f52154..7828b40 100644
--- a/qt-ui/subsurfacewebservices.cpp
+++ b/qt-ui/subsurfacewebservices.cpp
@@ -110,7 +110,7 @@ static char *prepare_dives_for_divelogs(const bool selected)
 	struct dive *dive;
 	FILE *f;
 	char filename[PATH_MAX], *tempfile;
-	size_t streamsize;
+	int streamsize;
 	char *membuf;
 	xmlDoc *doc;
 	xsltStylesheetPtr xslt = NULL;
@@ -173,7 +173,7 @@ static char *prepare_dives_for_divelogs(const bool selected)
 		}
 		free((void *)membuf);
 		transformed = xsltApplyStylesheet(xslt, doc, NULL);
-		xmlDocDumpMemory(transformed, (xmlChar **) &membuf, (int *)&streamsize);
+		xmlDocDumpMemory(transformed, (xmlChar **) &membuf, &streamsize);
 		xmlFreeDoc(doc);
 		xmlFreeDoc(transformed);
 		/*
-- 
1.7.11.7



More information about the subsurface mailing list