#176: Scroll wheel does mad things in Dive Info tab: tags and date/time field

Dirk Hohndel dirk at hohndel.org
Fri Dec 13 21:21:14 UTC 2013


I think I fixed this.

Linus can you check that this behavior is closer to what you had in
mind? Tomaz and Lubomir, can you stare at my code and re-assure me that
it's not completely braindead?

Thanks

/D

On Sat, 2013-12-14 at 05:19 +0000, Subsurface Bug Tracking System wrote:
> #176: Scroll wheel does mad things in Dive Info tab: tags and date/time field
> -------------------------------------+-------------------------------------
> Reporter:  torvalds                  |                                                 Owner:
>     Type:  defect                    |  Dirk Hohndel <dirk@…>
> Priority:  major                     |                                                Status:
>  Version:  current git - please      |  closed
>   provide SHA in your description    |                                             Component:
> Keywords:                            |  Qt-UI
>                                      |                                            Resolution:
>                                      |  fixed
>                                      |  Plattform (please give specifics in
>                                      |  the ticket text):  Linux
> -------------------------------------+-------------------------------------
> \
> \
> \
> \
> Changes (by Dirk Hohndel <dirk@…>):
> 
>  * owner:   => Dirk Hohndel <dirk@…>
>  * status:  reopened => closed
>  * resolution:   => fixed
> 
> \
> \
> \
> 
> Comment:
> 
>  In [changeset:"d117becad83a42f49e17bc151ce5ecc11e4dc8cf/subsurface"]:
>  {{{
>  #!CommitTicketReference repository="subsurface"
>  revision="d117becad83a42f49e17bc151ce5ecc11e4dc8cf"
>  Improve MainTab behavior when using the scroll wheel
> 
>  This gets the behavior close to what we really want.
>  - scroll wheel no longer enters edit mode when over the tabWidget
>  - scroll wheel doesn't modify dateTimeEdit, nor does it enter edit mode
>  - scroll wheel still scrolls both the notes and the full widget
> 
>  The only oddity is that when clicking on either the dateTimeEdit or the
>  tabWidget we don't immediately turn on the 'being edited' warning (as we
>  do for all the other widgets). For those two widgets the user has to press
>  a key before edit mode starts.
> 
>  I think this Fixes #176
> 
>  Reported-by: Linus Torvalds <torvalds at linux-foundation.org>
>  Ideas-by: Lubomir I. Ivanov <neolit123 at gmail.com>
>  Signed-off-by: Dirk Hohndel <dirk at hohndel.org>
>  }}}
> \
> \
> \
> 
> --
> Ticket URL: <http://trac.hohndel.org/ticket/176#comment:6>
> Subsurface <http://subsurface.hohndel.org>
> Subsurface Dive Log
> _______________________________________________
> Subsurface-trac mailing list
> Subsurface-trac at hohndel.org
> http://lists.hohndel.org/cgi-bin/mailman/listinfo/subsurface-trac




More information about the subsurface mailing list