[PATCH] Use UTF-8 for text strings.

Thiago Macieira thiago at macieira.org
Mon Dec 16 14:18:18 UTC 2013

On segunda-feira, 16 de dezembro de 2013 22:49:03, Michael Andreen wrote:
> Fixes #371
> Signed-off-by: Michael Andreen <harv at ruin.nu>

While the patch itself is fine, I'm not sure it's actually fixing anything. 
Michael, can you confirm that it does fix the problem?

The reason being that we set the "codec for C strings" early in the 
initialisation, so

	QString(text) == QString::fromUtf8(text)

[though with a different codec implementation and a small performance penalty. 
(I need to go fix the different codec problem for Qt 5, now that I've improved 
the performance of our UTF-8 codec 2.1x to 3.6x times on average data over 

[1] https://codereview.qt-project.org/69597

Thiago Macieira - thiago (AT) macieira.info - thiago (AT) kde.org
   Software Architect - Intel Open Source Technology Center
      PGP/GPG: 0x6EF45358; fingerprint:
      E067 918B B660 DBD1 105C  966C 33F5 F005 6EF4 5358
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 190 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.hohndel.org/pipermail/subsurface/attachments/20131216/48efadff/attachment.sig>

More information about the subsurface mailing list