[PATCH v2] Use UTF-8 for text strings.
Thiago Macieira
thiago at macieira.org
Mon Dec 16 15:12:22 UTC 2013
On segunda-feira, 16 de dezembro de 2013 23:50:42, Michael Andreen wrote:
> Fixes #371
>
> Signed-off-by: Michael Andreen <harv at ruin.nu>
> ---
>
> On Monday, December 16, 2013 02:18:18 PM Thiago Macieira wrote:
> > While the patch itself is fine, I'm not sure it's actually fixing
> > anything.
> > Michael, can you confirm that it does fix the problem?
> >
> > The reason being that we set the "codec for C strings" early in the
> > initialisation, so
> >
> > QString(text) == QString::fromUtf8(text)
>
> So I went a bit far with all the fromUtf8. The actual problem is just
> toLocal8Bit(). I managed to reproduce the problem on linux by using a latin1
> locale for LC_CTYPE and switching to toUtf8() fixes the problem.
Thanks, this one looks better!
--
Thiago Macieira - thiago (AT) macieira.info - thiago (AT) kde.org
Software Architect - Intel Open Source Technology Center
PGP/GPG: 0x6EF45358; fingerprint:
E067 918B B660 DBD1 105C 966C 33F5 F005 6EF4 5358
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 190 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.hohndel.org/pipermail/subsurface/attachments/20131216/e869ae13/attachment.sig>
More information about the subsurface
mailing list