[PATCH] Files: fix a path encoding issue on Windows

Thiago Macieira thiago at macieira.org
Tue Dec 17 08:40:14 UTC 2013

On terça-feira, 17 de dezembro de 2013 06:48:51, Dirk Hohndel wrote:
> Thiago, can I get an ACK from you for this patch, please?

ACK, but incomplete.

There are other places where we encode filenames to 8-bit. We should:

 - ensure that all file names are encoded with QFile::encodeName and decoded
   with QFile::decodeName
 - we initialise QFile on Windows (setEncodingFunction, setDecodingFunction)
 - fix other places where we open files, including zip_open[1]

I can do the first two. I see other open calls in save-xml.c and uemis-
downloader.c, plus the zip_open calls and one sqlite3_open.

[1] We need to fix libzip upstream with either an encoding mechanism for 
windows or a zip_wopen.

Thiago Macieira - thiago (AT) macieira.info - thiago (AT) kde.org
   Software Architect - Intel Open Source Technology Center
      PGP/GPG: 0x6EF45358; fingerprint:
      E067 918B B660 DBD1 105C  966C 33F5 F005 6EF4 5358
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 190 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.hohndel.org/pipermail/subsurface/attachments/20131217/86782479/attachment.sig>

More information about the subsurface mailing list