[PATCH 7/8] Webservices: use toUtf8() when dealing with files

Thiago Macieira thiago at macieira.org
Wed Dec 18 15:23:15 UTC 2013


On quinta-feira, 19 de dezembro de 2013 00:47:05, Lubomir I. Ivanov wrote:
> From: "Lubomir I. Ivanov" <neolit123 at gmail.com>
> 
> Looks like toLocal8Bit() when dealing with files that
> have special characters in the path is not a good
> option on win32.
> 
> These are not likely to break but we add the safety
> anyway.

This one is "damned you do, damned if you don't".

Strictly speaking, we should keep locale-encoded names for now on Windows, 
until we have zip_wopen. At least they're able to encode some file names, 
though not all. By switching to UTF-8 now, we force that everything needs to 
be US-ASCII only.

But let's not split hairs right now, this is the best we can do.

-- 
Thiago Macieira - thiago (AT) macieira.info - thiago (AT) kde.org
   Software Architect - Intel Open Source Technology Center
      PGP/GPG: 0x6EF45358; fingerprint:
      E067 918B B660 DBD1 105C  966C 33F5 F005 6EF4 5358
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 190 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.hohndel.org/pipermail/subsurface/attachments/20131218/a1a6125d/attachment-0001.sig>


More information about the subsurface mailing list