[PATCH 2/8] Files: add wrappers for open(), fopen(), sqlite3_open()

Thiago Macieira thiago at macieira.org
Wed Dec 18 16:29:34 UTC 2013


On quinta-feira, 19 de dezembro de 2013 02:10:54, Lubomir I. Ivanov wrote:
> On 19 December 2013 01:36, Thiago Macieira <thiago at macieira.org> wrote:
> > Yup. My point is that you could do an ASCII-to-UTF16 conversion instead:
> >         wchar_t wmode[strlen(mode) + 1];
> >         for (i = 0; i < strlen(mode); ++i)
> >         
> >                 wmode[i] = mode[i];
> 
> send an updated version of this patch that include this change and the
> other suggestions.
> i was confused about the char count a little but i think i got it now.

We can apply your change and I can do the improvements on top. Your change is 
technically correct, it's just that I think we can do it a little more 
optimally :-)

-- 
Thiago Macieira - thiago (AT) macieira.info - thiago (AT) kde.org
   Software Architect - Intel Open Source Technology Center
      PGP/GPG: 0x6EF45358; fingerprint:
      E067 918B B660 DBD1 105C  966C 33F5 F005 6EF4 5358
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 190 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.hohndel.org/pipermail/subsurface/attachments/20131218/de3793ba/attachment.sig>


More information about the subsurface mailing list