[PATCH 0/7] Fix broken file paths on Win32

Dirk Hohndel dirk at hohndel.org
Thu Dec 19 07:35:13 UTC 2013


On Thu, 2013-12-19 at 15:00 +0200, Lubomir I. Ivanov wrote:
> these are the rebased series from yesterday.
> includes thiago's suggestions and also the one
> from jef about the redundant sqlite wrapper.

Thank you. Much appreciated.

> compiles ok on win32/linux. please, test osx,
> but if there are issues on that let's send
> a separate patch on top of the series, and if
> possible.

Of course. Already applied, some more testing (I can now build test for
all three OSs on the same machine) and I'll push it out.

> the win32 issues seems to be solved, except that
> we cannot ZIP_CREATE files in odd paths yet, but
> i kinda do have a solution for that, but only
> for users who have sane win32 (e.g. US-ASCII)
> systemdirs.

I think we should make that assumption. MS by default ensures that, so
someone would have to do a custom install and intentionally move the
system dir to C:\Üßßö°\ - they get what they deserve.

> pro-tip: don't rebase messy trees post midnight. :\

I know that one well :-/

/D




More information about the subsurface mailing list