christmas patches.

Tomaz Canabrava tcanabrava at kde.org
Thu Dec 26 04:12:17 UTC 2013


Em 26/12/2013 09:45, "Patrick Valsecchi" <patrick at thus.ch> escreveu:
>
> Early optimization is root to all evil.
>
> Anyway this question is eluded by my one liner replacement.

Yes, it is. I do prefer your version. Can you send a patch ( with a sob
line)?

>
> Tomaz Canabrava <tcanabrava at kde.org> a écrit :
>>
>> Em 26/12/2013 08:23, "Tomaz Canabrava" <tcanabrava at kde.org> escreveu:
>>>
>>> Hy
>>> Em 26/12/2013 07:03, "Patrick Valsecchi" <patrick at thus.ch> escreveu:
>>> >
>>> > Hi,
>>> >
>>> > About the patch 0001:
>>> > http://qt-project.org/doc/qt-4.8/qstringlist.html#contains
>>> >
>>> > So that would be shorter:
>>> >
>>> > const bool foundGoogleMap =
list.contains("earth/googlesat/googlesat.dgml");
>>> >
>>> >
>>> > And, for your information, QString is copy on write. So a copy by
value is nearly costless.
>>>
>>> Nearly, but a benchmark showed that it's still costlier than a no copy
at all.  Yes, there's a qstringlist, but it's a qstring ( bigger than a
pointer)  on a qlist ( that the documentation on it says that's optimized
for the things of the size of a pointer.)
>>>
>>> >
>>> > CU
>>> >
>>> >
>>> > On 24. 12. 13 14:06, Tomaz Canabrava wrote:
>>> >>
>>> >> Mostly code-style issues, optimizations. only real bug was for dark
backgrounds.
>>> >>
>>> >>
>>> >>
>>> >> _______________________________________________
>>> >> subsurface mailing list
>>> >> subsurface at hohndel.org
>>> >> http://lists.hohndel.org/cgi-bin/mailman/listinfo/subsurface
>>> >
>>> >
>>> >
>>> > _______________________________________________
>>> > subsurface mailing list
>>> > subsurface at hohndel.org
>>> > http://lists.hohndel.org/cgi-bin/mailman/listinfo/subsurface
>>> >
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.hohndel.org/pipermail/subsurface/attachments/20131226/eedcceea/attachment.html>


More information about the subsurface mailing list