[PATCH] Implement a 'Save As' entry in the context menu shown when right click on a dive

Dirk Hohndel dirk at hohndel.org
Fri Feb 1 00:12:53 PST 2013


Pierre-Yves Chibon <pingou at pingoured.fr> writes:

> Something which is nice especially when asked on the list to share an
> interesting dive is the possibility to save just some dives into a file.
>
> This commit adds to the context menu showns with right-click the 'Save As'
> entry. This entry allows to save selected dives.
>
> Signed-off-by: Pierre-Yves Chibon <pingou at pingoured.fr>
> ---
>
> I think this approach is nicer than the previous one, only the name of the
> function 'save_dives_logic' is not really nice, suggestions welcome.

That I can live with. What I absolutely don't like is that the file
selectbox is populated with the default filename. It is WAY to easy to
overwrite your data file with the dives that you have selected. And that
could cause us some seriously unhappy users...

Please fix and resend.

/D


More information about the subsurface mailing list