Add window save/restore

Dirk Hohndel dirk at hohndel.org
Sun Feb 3 12:34:52 PST 2013


Henrik Brautaset Aronsen <subsurface at henrik.synth.no> writes:

> Dirk Hohndel wrote:
>> Amit Chaudhuri<amit.k.chaudhuri at gmail.com>  writes:
>>> For Linux I have made the necessary changes to linux.c, but on windows and
>>> OSX I provide function stubs to invite others to complete. Anyone?
>>
>> I am a bit torn whether to include this in its current form... I've seen
>> Henrik's Mac change, maybe if Lubomir sends the corresponding Windows
>> change I'll consider it... But for a couple of issues below I'll ask you
>> to re-create this patch...
>
> Fingers crossed for having this functionality in 3.0.    I *always* 
> resize Subsurface after startup, and due to some GTK bug/feature it's 
> not always easy to resize.  It takes a couple of tries with 
> click-and-drag before I manage to resize.  So this patch would be very 
> helpful :)

So here are some of our concerns:

- four integers seems silly. Why not a string like "widthxheight at x,y".
  that's trivial to parse, uses a string, doesn't clutter the config
  space
- what does this do if it gets bogus values. Imagine you attach a second
  monitor (people with laptops often do at home) and move the window to
  that (x coordinate is now larger than the resolution of your laptop
  screen); remove the second monitor and start Subsurface again. Is it
  still visible or is it drawn all the way to the right beyond where you
  can see it and the only way to get it back is to hand-endit the config
  (NACK on that one)
- similarly, what happens if you resize it to your huge secondary screen
  and then you disconnect that screen... 

So if we can get this to use one string and if the resulting sizes /
coordinates get validated so that we KNOW the window will fit on the
current screen... then yes, I'll take it for 3.0.

/D


More information about the subsurface mailing list