Printing issues on Mac [was [PATCH] Change default MacOS font]

[Lubomir I. Ivanov]

On 6 February 2013 00:34, Henrik Brautaset Aronsen
<subsurface at henrik.synth.no> wrote:
> On Tue, Feb 5, 2013 at 11:29 PM, Lubomir I. Ivanov <neolit123 at gmail.com>
> wrote:
>>
>> some other notes:
>> i always get this warning when printing with my locale (bg_BG):
>> (subsurface.exe:1992): Pango-WARNING **: Invalid UTF-8 string passed to
>> pango_la
>> yout_set_text()
>> W: T: T
>> which perhaps suggests incorrect truncation of UTF-8 strings somewhere
>> in print.c.
>
>
> FYI:  I got the same error in
> https://github.com/torvalds/subsurface/commit/9b47dc1f5920be228d2b4e6b91f361a52d40eb87,
> but it was not (directly) related to UTF-8 problems.  It might be in this
> case, though..
>

ouch, every single snprintf() in print.c can potentially break unicode strings!
the large triangle thing is related to this stub in my case:

	utc_mkdate(dive->when, &tm);
	len = snprintf(buffer, sizeof(buffer),
		/*++GETTEXT 80 chars: lead text ("" or localized "Dive #%d - ")
weekday, monthname, day, year, hour, min */
		_("%1$s%2$s, %3$s %4$d, %5$d   %6$d:%7$02d"),
		divenr,
		weekday(tm.tm_wday),
		monthname(tm.tm_mon),
		tm.tm_mday, tm.tm_year + 1900,
		tm.tm_hour, tm.tm_min);

i will try spending some time tomorrow to replace all of those with UTF logic.
can you please try the patch i've send in the previous message on osx?

lubomir
--