[PATCH 2/2] Support for Imperial units on MacDive log import

Miika Turkia miika.turkia at gmail.com
Thu Feb 7 23:14:10 PST 2013


On Fri, Feb 8, 2013 at 8:11 AM, Nick Shore <support at mac-dive.com> wrote:
>
> On 08/02/2013, at 6:47 PM, Miika Turkia <miika.turkia at gmail.com> wrote:
>
>> Thanks Nick, I think this is much clearer now. Even though the
>> Imperial units are and will always be a mess from my point of view.
>
> My ones, or Imperial in general? Happy to make any changes that make life easier - I haven't released this update yet so it's no drama to change.

Imperial in general :)

The main trouble with the format is the fields that are not well
defined. E.g. weight seems to be a text field and I have seen samples
that have only a number on it and samples with 10kg on it. My current
conversion (not yet public) takes the best guess on this. Pure number
is treated as being the unit specified (Metric or Imperial) - a safe
assumption I believe. Anything else is passed to Subsurface parser
hoping for the best. At least value like 10kg is treated properly in
this case and totally bogus data is discarded as far as I know.

Just to make sure, is the second dive in your sample with bogus
pressure readings (pressure going up and down without making sens,
ending up with higher value than started with)?

miika


More information about the subsurface mailing list