Saving air temperature

[Dirk Hohndel]

On Feb 14, 2013, at 7:40 AM, Lubomir I. Ivanov wrote:

> On 14 February 2013 16:31, Sergey Starosek <sergey.starosek at gmail.com> wrote:
>> Hi,
>> 
>> Seems that air temperature saving is broken. If you edit the dive, modify
>> air temp, press Ok, and the reopen for edit, one can see these changes.
>> But it's neither shown on the 'Dive Info' tab, nor saved to the XML. If this
>> information is supposed to be downloaded from DC, then editing air temp
>> should not modify dive (or better disable this edit box).
>> 
> 
> i've just sent a patch for this named:
> [PATCH] Store user entered 'airtemp' values in the 'divecomputer' struct
> 
> but i'm not sure if this is desired, as currently there are couple of
> places to store air temp.
> i'm guessing that the 'dc' airtemp is a value that can be retrived
> from a DC, and perhaps the
> user value should only be stored directly in the dive struct. then
> again save-xml.c and statistics.c
> seem to be only interested in the DC value. some additional logic may
> be required here.

save-xml.c needs to be updated to save the value.
more interestingly, statistics.c at this point only displays the air temperature 
that we get from the divecomputer that is currently displayed. I mentioned
last week that we need a way to display the "best information we have" kind
of summary somewhere - but we don't at this point.

Maybe I'll have statistics.c display the data in the dive structure if it was 
manually set to override what's in the divecomputer…

/D
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 4130 bytes
Desc: not available
URL: <http://lists.hohndel.org/pipermail/subsurface/attachments/20130214/0bd7379a/attachment-0001.bin>