Still in time to change the table print ?

Dirk Hohndel dirk at
Sun Feb 17 11:31:35 PST 2013

Miika Turkia <miika.turkia at> writes:

> On Sun, Feb 17, 2013 at 10:59 AM, Dirk Hohndel <dirk at> wrote:
>> On Feb 17, 2013, at 12:39 AM, Dirk Hohndel wrote:
>>> I am in the middle of doing correct pagination for the tables. The way the tables look right now isn't all that great, either. More patches forthcoming (hopefully soon)
>> OK, I just pushed two more changes:
>> - correctly size the table rows based on the actual calculated heights (i.e., the space around the lines of text is now calculated based on the height of a single line of text)
>> - correctly paginate the table based on those cumulative row heights
>> This obviously requires a bit of testing, but I think it's a nice step forward for the table printout which was just not a highlight for Subsurface…
> Would it be possible to move the 'Dive details' tab to be the first
> tab in the printing dialog? The current position is easily missed
> unless user is really keen on checking all the possible configuration
> options.

Sadly you can't. It's hooked up in a signal callback and you can't get
to the parent structure until after it has already been rendered (it
would be easy to reorder the notebook pages if you could get a pointer
to the notebook BEFORE it gets rendered - but whatever I tried, that
doesn't appear to be possible).

What I did instead is that I renamed the tab (the name 'Dive details'
wasn't great and the localization in some languages was definitely
misleading) and changed it's layout once selected. I went with a string
that we already use (to avoid another round of new translations) -
please take a look if this is somewhat better.


More information about the subsurface mailing list