[PATCH] Select all dives in a trip when said trip is expanded and clicked

[Dirk Hohndel]

"Lubomir I. Ivanov" <neolit123 at gmail.com> writes:

> From: "Lubomir I. Ivanov" <neolit123 at gmail.com>
>
> This patch selects visually all dives within a trip when a
> trip is expanded (using gtk_tree_selection_select_iter()).
> If the trip is not expanded it only selects the dives
> as data (using select_dive()).
>
> When calling get_iter_from_idx(), make sure we free memory at
> the returned address.

Yes, I think this is an improvement over the current situation. 
I have not been able to create a situation where this creates a
regression.

It still has one flaw that isn't addressed:

Expand a trip.
Select a dive in the trip
Collapse the trip - all dives in the trip are selected
Expand the trip - all dives are selected

This is not a new bug that you introduced, Lubomir, this is a
shortcoming of Linus' implementation.

I just wanted to point out that that one is still not fixed.

/D