[PATCH] When only a dive trip is selected, select all the dives in the trip

Dirk Hohndel dirk at hohndel.org
Mon Feb 18 16:21:04 PST 2013


Linus Torvalds <torvalds at linux-foundation.org> writes:
>
> This gets you the expected behavior for almost all cases. But note the 
> "user unselected just the dive trip entry". We really don't know whether 
> the user meant to unselect all the dives under the trip or just the trip 
> entry, and we have no really sane way to find out.
>
> We could have more insane heuristics like "if the only change in selection 
> was the dive trip, let's unselect all the dives under it too", but it 
> really gets to be too crazy. I don't think it matters from a UX 
> standpoint.

Agreed. I think this is a HUGE improvement from what we had before AND
it fixes Amit's issue.

I just pushed this.

Thanks to Lubomir for proposing several attempts to fix this issue - and
thanks to you for jumping on this on a weekend where you are also trying
to get a Linux release ready...

/D


More information about the subsurface mailing list