[PATCH] When only a dive trip is selected, select all the dives in the trip
Lubomir I. Ivanov
neolit123 at gmail.com
Mon Feb 18 16:21:46 PST 2013
On 19 February 2013 01:43, Linus Torvalds <torvalds at linux-foundation.org> wrote:
>
> From: Linus Torvalds <torvalds at linux-foundation.org>
> Date: Mon, 18 Feb 2013 15:35:47 -0800
> Subject: [PATCH] When only a dive trip is selected, select all the dives in the trip
>
> This does a final pass after all the selection logic, and notices if we
> have dive trips that are selected, but that have no dives in them
> selected. In that case, we assume that the user wanted to select all
> dives in that trip.
>
> NOTE! This still allows a range selection that selects the dive trip
> entry and a few dives under the trip. If a trip has any dives selected
> in it, we leave that manual selection alone. So this new logic really
> only triggers on the case where somebody selected *just* the trip.
>
> Note: unselecting the trip still leaves the dives under it selected,
> because having a dive trip that isn't selected have all the dives under
> it be selected is normal, and we can't recognize that as some kind of
> special event.
>
i think it works as expected. obviously much better than my previous attempts.
i'm surprised by the workaround lengths for the simplest of functionality. :[
Tested-by: Lubomir I. Ivanov <neolit123 at gmail.com>
lubomir
--
More information about the subsurface
mailing list