[PATCH] Select all dives in a trip when said trip is expanded and clicked

Dirk Hohndel dirk at hohndel.org
Mon Feb 18 17:01:49 PST 2013


On Feb 18, 2013, at 3:35 PM, Linus Torvalds wrote:

> On Mon, Feb 18, 2013 at 2:46 PM, Linus Torvalds
> <torvalds at linux-foundation.org> wrote:
>> 
>> No, not only does the selected_dive go away, we also have zero selected dives.
>> 
>> It's just the statistics window that doesn't update. There's probably
>> some logic along the lines of "nothing selected, so don't bother
>> updating the statistics". So the "Stats" notebook keeps showing the
>> old selection state.
> 
> Ok, the cause for that is that "update_dive()" only does the
> "show_dive_stats(new_dive);" thing if "new_dive" is non-NULL.
> 
> So any time there is no current dive, we stop updating statistics, and
> show the old stats.
> 
> If somebody wants to fix it, you'll need to make show_dive_stats()
> able to handle a NULL dive, and then call it unconditionally, the same
> way we call show_dive_info() unconditionally whether we have a dive or
> not.

Done and pushed.

please test.

/D


-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 4130 bytes
Desc: not available
URL: <http://lists.hohndel.org/pipermail/subsurface/attachments/20130218/307bf0c4/attachment.bin>


More information about the subsurface mailing list