[PATCH] Select all dives in a trip when said trip is expanded and clicked

[Lubomir I. Ivanov]

On 19 February 2013 07:06, Miika Turkia <miika.turkia at gmail.com> wrote:
>
> I did a quick test with the sample dives.
> - Expand the trip
> - Select one dive
> - Collapse the trip
> - Select a dive that is not on a trip
> - Expand the trip
>
> Oddities from my point of view:
> - There is no visual indication that one or more dives from a trip is
> selected when the trip is collapsed
> - When selecting a dive without modifiers one expects that other
> selections are cleared. This is not the case when dives are selected
> in a collapsed trip. This shows on the dive stats and when you expand
> the trip.
> - Now if I select a trip none of the dives within are selected - no
> matter whether the trip is collapsed or expanded (not sure what was
> the intended behaviour on this but I thought all the dives would be
> selected)
>

i first thought you are talking about my patches, but then realized
it's about linus' patch in the current master.

strangely i had a test XML for this particular issue, while i was
"attempting" yesterday and i wasn't able to reproduce your steps with
it.
but doing a ./subsurface ./dives/* i can confirm all of that.

a single trip with a couple of dives is formed (26, 27) where the
selection of a dive inside is preserved, when the trip is collapsed.
also like you explain selecting a trip does not select all dives
within, regardless of collapsed or expanded states.

this is weird, perhaps its somehow related to the new fixup flag and
default xml files.

lubomir
--