[PATCH] Select all dives in a trip when said trip is expanded and clicked

[Lubomir I. Ivanov]

On 19 February 2013 17:48, Lubomir I. Ivanov <neolit123 at gmail.com> wrote:
> On 19 February 2013 17:38, Linus Torvalds <torvalds at linux-foundation.org> wrote:
>> On Mon, Feb 18, 2013 at 9:06 PM, Miika Turkia <miika.turkia at gmail.com> wrote:
>>> - Now if I select a trip none of the dives within are selected - no
>>> matter whether the trip is collapsed or expanded (not sure what was
>>> the intended behaviour on this but I thought all the dives would be
>>> selected)
>>
>> Again, for me, if a trip is selected when expanded, I get all dives
>> selected (now, with my patch) and if it was collapsed it always did
>> that for me.
>>
>> [ trying some more ]
>>
>> .. uhhuh - I notice that Lubomir says he can recreate it with
>>
>>     ./subsurface dives/*
>>
>> and it turns out that I can recreate it with that too. But not with my
>> own dives.
>>
>> Odd. I think I agree with Lubomir - there's something about the mixed
>> "in-trip" and "not in trip" dives that triggers this.
>>
>> Will look.
>>
>
> i think the last part can be fixed with this:
> (attached patch)
>
> we may need to set the fixup flag for a trip when auto-group is performed?
> seems to work with */dives.xml.
>

huh, just tried again and it doesn't work.
please ignore me...not sure what i did.

lubomir
--