[BUG] Default sorting order and deleting a trip, while switching sorting orders

[Dirk Hohndel]

"Lubomir I. Ivanov" <neolit123 at gmail.com> writes:

> On 19 February 2013 19:55, Linus Torvalds <torvalds at linux-foundation.org> wrote:
>> On Tue, Feb 19, 2013 at 9:10 AM, Lubomir I. Ivanov <neolit123 at gmail.com> wrote:
>>> just noticed a couple of things, which might have been lurking for
>>> quite some time.
>>
>> Yeah, these are not new.
>>
>>> 1) (more of a nitpick) the default sorting order in the divelog isn't
>>> correctly indicated when the app. is first started.
>>
>> This is normal gtk behavior. The initial ordering isn't really a
>> "sorted" order, it's just the native order of the tree model (ie the
>> order we've filled it in). The fact that we our native order is the
>> same as the trip-date order is just happenstance.
>>
>
> perhaps it's still best to provide the visual indication to the user,
> that there is some sorting order in action when the app. starts, even
> if its not 100% the same as manually clicking on a column title. i.e.
> we are sorting by "date" so the column should have the arrow
> indication (up or down - i'm not sure) show on app. start.
>
> just found this in the GTK docs:
> gtk_tree_view_column_set_sort_indicator
>
> it pre-sets the sorting indicator when the app. starts.
> (example patch attached, but it follows # - explanation below)
>
> but i've noticed that trips are now only visible if we select the
> "dive_list.nr" column, i can recall that this was the case for the
> "date" column only.
> hm, so if dives and trips are sorted by date on import, why are the
> trips rows only visible for the # column?

Because trips allow for dives with overlapping date ranges - so sorting
by date really sorts all the dives by date.

I don't see really compelling reason to apply the patch. It doesn't
really fix a bug per se.

/D