[PATCH] Rewrite "merge_dive_into_trip_above()" using our own data structures

Henrik Brautaset Aronsen subsurface at henrik.synth.no
Tue Feb 19 12:04:55 PST 2013


Dirk Hohndel wrote:
> Linus Torvalds<torvalds at linux-foundation.org>  writes:
>> because we simply don't need to worry about the gtk tree model, we just do
>> the fairly simple "move dive (or selected dives) into trip".
>>
>> ..and I'm done. I don't think we have any gtk-traversing dive-editing
>> functions left. All the gtk traversal is now just to find the right dive,
>> or to find the next/previous dive/trip etc (which depends on sort order
>> etc, so we do want to actually use the gtk model accessor stuff for that)
>
> This is outstanding. I would have preferred this a few days earlier, but
> reading the changes they do look like a huge improvement.


I agree, this is good shit.  It behaves well on MacOSX as far as I can se.

H
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.hohndel.org/pipermail/subsurface/attachments/20130219/388eb10c/attachment.html>


More information about the subsurface mailing list