[PATCH] Remember pre-existing trip expansion state when autogrouping
Dirk Hohndel
dirk at hohndel.org
Tue Feb 19 13:20:26 PST 2013
Linus Torvalds <torvalds at linux-foundation.org> writes:
>
> We should probably aim to do the whole "restore tree state" in
> dive_list_update_dives() unconditionally. Right now, almost all of the
> callers do it, and the two remaining cases (main.c and webservice.c
> should probably do it too.
I just noticed that webservice has them all collapse which is really
strange... the same dive stays selected, but it's no longer visible.
> Then, if we just made the collapse/expand callbacks update the
> trip->expanded flag, we could remove all the "save/restore" state
> entirely, and updating the divelist would just automatically maintain the
> previous state.
Would you do that to finish off this series? It seems like the logical
conclusion.
I have moved the release date to Thursday so this can get plenty of
testing...
/D
More information about the subsurface
mailing list